For single argument ctors, mark type explicit.

diff --git a/sort.h b/sort.h
index 68e610f1f0e2fcbd197d7af9d91ea77cf96b78e8..8bf31b6f028b7580daf24d1f474799af3c4b0583 100644 (file)
--- a/sort.h
+++ b/sort.h
@@ -114,7 +114,7 @@ private:
   class SortCompWptFunctor
   {
   public:
-    SortCompWptFunctor(SortFilter& obj) : that(&obj) {}
+      explicit SortCompWptFunctor(SortFilter& obj) : that(&obj) {}
     int operator()(const queue* a, const queue* b);
 
   private:
@@ -124,7 +124,7 @@ private:
   class SortCompRteHdFunctor
   {
   public:
-    SortCompRteHdFunctor(SortFilter& obj) : that(&obj) {}
+      explicit SortCompRteHdFunctor(SortFilter& obj) : that(&obj) {}
     int operator()(const queue* a, const queue* b);
 
   private:

diff --git a/src/core/file.h b/src/core/file.h
index 0f16350df85bb65ef8d94aef03d588aa9c420f46..d8357c72e54e6d0831bc3b1f11a6e405e97a81a2 100644 (file)
--- a/src/core/file.h
+++ b/src/core/file.h
@@ -30,7 +30,7 @@ namespace gpsbabel
 class File : public QFile
 {
 public:
-  File(const QString& s) : QFile(s) {}
+    explicit File(const QString& s) : QFile(s) {}
 
   /* in the tradition of gbfile we assume WriteOnly or ReadOnly, not ReadWrite */
   bool open(OpenMode mode) override {

diff --git a/src/core/logging.h b/src/core/logging.h
index b8572de99fe5adfdce76ac78c8b266bb2e4c48fa..40e832e1d5b71c5d69b147148845c42985f20e9b 100644 (file)
--- a/src/core/logging.h
+++ b/src/core/logging.h
@@ -28,7 +28,7 @@
 
 class Warning {
  public:
-  Warning(bool fatal = false) :
+    explicit Warning(bool fatal = false) :
    fatal_(fatal) {
     file_.open(stderr, QIODevice::WriteOnly);
     fileStream_.setDevice(&file_);

diff --git a/src/core/xmlstreamwriter.h b/src/core/xmlstreamwriter.h
index 829a421cf5818b32cca380455ed82454b1e46c6d..d99618186c99c34bf93bd0d216bee3b874302f2c 100644 (file)
--- a/src/core/xmlstreamwriter.h
+++ b/src/core/xmlstreamwriter.h
@@ -49,8 +49,9 @@ protected:
 class XmlStreamWriter : public QXmlStreamWriter
 {
 public:
-  XmlStreamWriter(QString* string);
-  XmlStreamWriter(QFile* f);
+    explicit XmlStreamWriter(QString* string);
+
+    explicit XmlStreamWriter(QFile* f);
 
   void writeStartDocument(void);
   void writeOptionalAttribute(const QString& qualifiedName, const QString& value);